Some style fixes - Githubissues

networkx / networkx-metis

NetworkX Addon to allow graph partitioning with METIS

Other

79 stars 21 forks source link

Some style fixes #27

Closed OrkoHunter closed 9 years ago

OrkoHunter commented 9 years ago

Fix https://landscape.io/github/OrkoHunter/networkx-metis/3/messages/error

binary-op-exception (W0711): Exception to catch is the result of a binary “%s” operation Used when the exception to catch is of the form “except A or B:”. If intending to catch multiple, rewrite as “except (A, B):”

It seems that populating networkx/addons/metis/__init__.py has generated a couple of cyclic imports. https://landscape.io/github/OrkoHunter/networkx-metis/3/messages/smell

~~They can be fixed by using from . import module which I think is okay to do.~~ Nope. Can't fix that.

SanketDG commented 9 years ago

Line 258 of this file and line 55 of test_metis.py longer than 79 chars. Might want to fix that.

OrkoHunter commented 9 years ago

@chebee7i You should turn on the option of "Build only if .travis.yml is present" option.

chebee7i commented 9 years ago

You are a maintainer on it, so you should configure it however networkx-metis needs it to be configured.

OrkoHunter commented 9 years ago

You are a maintainer on it

I don't have the option to configure it (Travis?). I guess only owners and collaborators can do it.

chebee7i commented 9 years ago

Oh sorry you meant for travis....yeah, I was referring to readthedocs.

OrkoHunter commented 9 years ago

I edited the long line of this file. The line in test_metis.py is of 80 columns, I wouldn't mind it. However the complete tests are to be re-written ( #26 ) so I guess things would be covered.

OrkoHunter commented 9 years ago

Are we good here?