search

networkx / networkx-metis

NetworkX Addon to allow graph partitioning with METIS
Other
79 stars 21 forks source link

Add tests inside installed package #33

Closed OrkoHunter closed 9 years ago

OrkoHunter commented 9 years ago

We need this at first place for the tests to run inside site-packages.

chebee7i commented 9 years ago

Why not just add an __init__.py file in the tests subdirectory? How you have it currently is different from how we do it in networkx. Not saying that they necessary need to be the the same though...

OrkoHunter commented 9 years ago

Having package_data for including tests (as it is in NetworkX) seems okay to me.

chebee7i commented 9 years ago

It seems like putting them in package_data contradicts the fact that we have __init__.py files in the test directories. E.g., in networkx (and maybe here), we should just add the test directories to packages. This would simplify package_data quite a bit.

OrkoHunter commented 9 years ago

Perfect. Added it into packages.

chebee7i commented 9 years ago

I think this requires that you have an empty __init__.py in the tests subdirectory.

chebee7i commented 9 years ago

Opps I'm blind.

OrkoHunter commented 9 years ago

Thanks! I'll rebase and run the travis script.