search

networkx / networkx-metis

NetworkX Addon to allow graph partitioning with METIS
Other
79 stars 21 forks source link

Drop x64 testing on appveyor #47

Closed OrkoHunter closed 9 years ago

OrkoHunter commented 9 years ago

Fixes #41

ysitu commented 9 years ago

Please add a comment explaining why you need to do this and what it takes to reenable x64 testing.

OrkoHunter commented 9 years ago

First, the default install of msvc does not support 64-bit tools, nevertheless the compiler for x64 is always present in the system with VS express. So, setuptools cannot work with a 64-bit Python install. However it does work for the default 32-bit arch.

This is an unresolved bug related to building a python package with msvc on x64 Windows arch. https://bugs.python.org/issue7511

However, there are temporary fixes for the build to work. Here is one little bad method of doing it manually. However, there is a better way of the same. The reason vcvarsall.bat is complaining that it can't find x64 compilers even if they are correctly installed in the Visual Studio VC folder, is that the Paths set inside the file are wrong. One can change the Paths according to their drive and folder locations and the build should work just fine. Here is an example patch

Now, Over a CI (AppVeyor) environment, I think it's not easy enough to apply the no-robust fix to make the x64 builds run. Rather we stop testing them over CI. And also, it's not like that we are dropping any Python version, it's just an architecture.

ysitu commented 9 years ago

Sorry for being vague. I meant a comment in appveyor.yml. Now that you have typed that up, you can add a line in the file to refer to this PR.

OrkoHunter commented 9 years ago

No problem. I added couple lines in the file.