search

networkx / nx-guides

Examples and Jupyter Notebooks about NetworkX
https://networkx.org/nx-guides/
Creative Commons Zero v1.0 Universal
192 stars 104 forks source link

Issue on page /content/algorithms/dag/index.html #128

Closed AniruddhMohan closed 2 months ago

AniruddhMohan commented 7 months ago

I came across 2 problems on the page:

  1. In this line in 'Step 3':

We process all the vertices of the current level in variable this_generation and we store the next level in variable zero_degree.

'zero_degree' should instead be 'zero_indegree'.

  1. The 'Suggest edit' link does not work on the page https://networkx.org/nx-guides/content/algorithms/dag/index.html It leads to the following: image
rossbar commented 7 months ago

Thanks for raising @AniruddhMohan ! The broken "edit this page" button is a known issue related to the use of symlinks.

If you'd like to take a stab at editing: https://github.com/networkx/nx-guides/blob/3533b8998753bfd38c30bab3d92708d79f7d638f/content/algorithms/dag/index.md?plain=1#L259

AniruddhMohan commented 6 months ago

Hi @rossbar , thanks for the pointer. I've raised a PR with the fix for the typo. https://github.com/networkx/nx-guides/pull/129