search

networkx / nx-guides

Examples and Jupyter Notebooks about NetworkX
https://networkx.org/nx-guides/
Creative Commons Zero v1.0 Universal
185 stars 105 forks source link

Adding tutorial for dinitz algorithm #46

Closed harshal-dupare closed 2 years ago

rossbar commented 2 years ago

To summarize the situation: the tutorial is excellent, but the main blocker to merging is that merging the PR would be adding 20ish MB to the commit history because all of the images (particularly the gif) are pre-computed elsewhere and linked to in the notebook, rather than generated during execution. Adding the code for generating the gif in a non-executed cell was an improvement, but didn't help on the commit-size front since the images were all loaded from file

I spent some time to refactor the notebook so that now the images are generated during execution. It was a fair amount of work, but in the end I think it's necessary to help move this across the finish line! Note that in the end I didn't end up replacing the gif - all of the pieces are in place to do so, but it would be a significant task that I thought could be left for a followup.

MridulS commented 2 years ago

Thanks for you work on this @harshal-dupare @rossbar! This is great. I went through this once, and it looks good to go, we can iterate on this further if required in a new PR :)