search

networkx / nx-guides

Examples and Jupyter Notebooks about NetworkX
https://networkx.org/nx-guides/
Creative Commons Zero v1.0 Universal
185 stars 105 forks source link

sudoku notebook #52

Closed mjhajharia closed 2 years ago

mjhajharia commented 2 years ago

this PR adds a notebook that explains and visualizes sudoku as a graph coloring problem using networkx

Reference: https://github.com/networkx/networkx/discussions/5085#discussioncomment-1435440

cc: @dschult @rossbar

rossbar commented 2 years ago

Thanks @mjhajharia , I'm looking forward to taking a look at this!

In order to facilitate the review process, it'd be really helpful to have a pull request originating from a branch that reviewers (like me) can push to. This makes it easy to fix things that are related to the infrastructure (fixing the failing CI, for example) quickly so that we can focus on the notebook!

This PR looks like it originates from you main branch, which makes it difficult to track your remote branch locally. If you're comfortable doing so, would you mind submitting a new PR from a non-main branch? For example, you could do something like:

git checkout main  # Make sure you're on the main branch
git pull  # Make sure you're up-to-date with your remote
git checkout -b sudoku-notebook  # where "sudoku-notebook" is now the new branch name. You can choose whatever name you'd like!
git push -u origin sudoku-notebook  # create your remote branch

At that point, you should be able to open a new PR from the sudoku-notebook branch instead of main.

LMK if you're comfortable with this - if not, no worries! I'm happy to iterate and find a solution that works for everyone!

mjhajharia commented 2 years ago

hi! @rossbar thanks for being patient, yeah i'm pretty comfortable with git it's been some years i do make branches for small patches when i'm regularly contributing to a library, but yeah it's a better practice, thanks! i've been really occupied so i'm getting back so late, apologies! closing this in favor of #54