search

networkx / nx-guides

Examples and Jupyter Notebooks about NetworkX
https://networkx.org/nx-guides/
Creative Commons Zero v1.0 Universal
192 stars 104 forks source link

SNA on contact #73

Closed Lukong123 closed 1 year ago

Lukong123 commented 2 years ago

Hello sir @MridulS, please sir I can't figure out why these checks are failing. Please can you enlighten me more?

rossbar commented 2 years ago

It looks like this PR actually includes the changes from #70 as well. It'd be best to split that out - if you're comfortable rebasing/cherry-picking you should be able to drop the commits related to the distance_measures notebook. If not, it's also fine just to git rm the distance measures directory (everything will be squashed at merge time anyways!) LMK if you have any questions!

Lukong123 commented 2 years ago

It looks like this PR actually includes the changes from #70 as well. It'd be best to split that out - if you're comfortable rebasing/cherry-picking you should be able to drop the commits related to the distance_measures notebook. If not, it's also fine just to git rm the distance measures directory (everything will be squashed at merge time anyways!) LMK if you have any questions!

Okay sir, thanks for pointing that out, I am not yet comfortable with rebasing/cherry-picking I'll try using git rm instead. so I think I will leave just https://github.com/networkx/nx-guides/pull/73/commits/a9d21719e3bac9307e5e24d967965b551a9e5970 and https://github.com/networkx/nx-guides/pull/73/commits/3d04e24438eaedf9d7464b1c431e3192697935c8

rossbar commented 1 year ago

I'm going to go ahead and close this as it's been stale for a while and still has the "changesets from multiple PRs" issue. @Lukong123 if you're still interested in working on this, the place to start would be to isolate the changes that were intended to be in this PR and push those up. Please feel free to reopen after doing so!