search

networkx / nx-parallel

A networkx backend that uses joblib to run graph algorithms in parallel.
BSD 3-Clause "New" or "Revised" License
34 stars 21 forks source link

Add parallel version of edge_betweenness_centrality #60

Closed jkrajniak closed 5 months ago

jkrajniak commented 7 months ago

This adds parallel setup for https://networkx.org/documentation/stable/reference/algorithms/generated/networkx.algorithms.centrality.edge_betweenness_centrality.html

dschult commented 5 months ago

Looks like all tests pass now. @Schefflera-Arboricola can you check your comments as "resolved" -- or leave more comments, or another review. When it's ready, select the "Approve" button while leaving a review. Thanks for this PR @jkrajniak

Schefflera-Arboricola commented 5 months ago

can you check your comments as "resolved"

no, I think only the author or maintainers can do that.

jkrajniak commented 5 months ago

can you check your comments as "resolved"

no, I think only the author or maintainers can do that.

You can just click on the "Resolve conversation" button for each of the comments.

dschult commented 5 months ago

Unless there is no button that says "Resolve conversation". :} I think github only allows resolving conversations for maintainers and the original poster. We are working on getting maintainer status for @Schefflera-Arboricola -- proper channels and all that. Meanwhile I resolved those that I think have been addressed. I wasn't sure about one where ruff made changes so it should be looked at. The ruff changes are usually "linting" changes, e.g. formatting, whitespace and indentation/line wraps changes. So it's probably OK.

Schefflera-Arboricola commented 5 months ago

Meanwhile I resolved those that I think have been addressed.

Thanks!

I wasn't sure about one where ruff made changes so it should be looked at. The ruff changes are usually "linting" changes, e.g. formatting, whitespace and indentation/line wraps changes. So it's probably OK.

There were no style changes(or any changes) in that file. I'm not sure what @jkrajniak was referring to there.

dschult commented 5 months ago

I am assuming that we don't get to see the changes. They were probably made by pre-commit locally before pushed to the repo -- so we would not see them. It all looks good from my perspective too, so I will resolve that comment. Thanks!