search

networkx / nx-parallel

A networkx backend that uses joblib to run graph algorithms in parallel.
BSD 3-Clause "New" or "Revised" License
23 stars 20 forks source link

MAINT: Switching to setuptools #69

Closed Schefflera-Arboricola closed 2 months ago

Schefflera-Arboricola commented 3 months ago

origin PR https://github.com/networkx/nx-parallel/pull/67 (Now, PR#67 is for adding additional linting settings in the future)

This PR switches the nx-parallel's building tool from hatchling to setuptools as it is more widely used and it's better for bigger projects and we need to explicitly mention all the packages(unlike hatchling) so that ensures that all packages are being built.

pre-file-ignores under tool.ruff.lint section due to the following warning:

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'select' -> 'lint.select'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
dschult commented 2 months ago

Can you edit the OP in this PR to describe what this does now and how it relates to #67? I think it would b hard for someone to come to this PR and figure out the current status of the change without more description here. Thanks!

dschult commented 2 months ago

Let's go ahead and merge this -- we can update further if other issues arise.