search

networkx / nx-parallel

A networkx backend that uses joblib to run graph algorithms in parallel.
BSD 3-Clause "New" or "Revised" License
34 stars 21 forks source link

Updating `prettier` in `.pre-commit-config.yaml` #73

Open Schefflera-Arboricola opened 3 months ago

Schefflera-Arboricola commented 3 months ago

The repository we currently use for the prettier hook has been archived.

https://github.com/networkx/nx-parallel/blob/a361b694859729811d070bd2d32d9b6c3861bef5/.pre-commit-config.yaml#L9-L14

I think we should switch to something else.

Thank you :)

[EDIT] - networkx also uses the same archived repository. So, maybe we should consider updating that also.

MridulS commented 3 months ago

Maybe we can look if we can get ruff to work with prettier, related https://github.com/astral-sh/ruff/issues/10738

jarrodmillman commented 3 months ago

We may just want to do this for now: https://github.com/scientific-python/cookie/pull/467

Schefflera-Arboricola commented 3 months ago

We may just want to do this for now: scientific-python/cookie#467

There wasn't any discussions below the PR you(@jarrodmillman) have mentioned. So, how exactly does using this particular fork fixes this issue?

Thank you :)

Schefflera-Arboricola commented 2 months ago

https://github.com/networkx/nx-parallel/pull/80#discussion_r1766310879

adding here for reference; seems related