netwrix / pingcastle

PingCastle - Get Active Directory Security at 80% in 20% of the time
https://www.pingcastle.com
Other
2.35k stars 292 forks source link

more typos fixed #173

Closed ruppde closed 1 year ago

vletoux commented 1 year ago

Thanks for submitting these changes I can approve the sentences change in the rule description file. but not the changes in the risk control file. Indeed, the UI became awful (there is no new line in your change - did you tested it ?).

I'm proposing this change instead: image

<h2>Risk model <i class=""info-mark d-print-none has-tooltip"" data-bs-placement=""bottom"" title="""" data-bs-original-title=""Left-click on the headlines in the boxes for more details."">?</i></h2> here: https://github.com/vletoux/pingcastle/blob/master/Report/ReportRiskControls.cs#L109

ruppde commented 1 year ago

sorry, didn't test it because I thought that new line would work right out of the box. but I showed the feature to colleague today, who has read numerous pingcastle -reports in the past. he was neither aware of the possibility to left click there and loved it :)

that help icon would help a bit, but the perfect solution would be make it visible in common UI terms, that the boxes are clickable, like underlined text for hyperlinks, or buttons. but that would probably look awful here. another good hint might be changing mouse pointer, if it's moved over the boxes. could be done like this:

https://www.tutorialrepublic.com/codelab.php?topic=faq&file=css-make-the-cursor-a-hand-pointer-on-hover

another hint could be given in the title, because that's just "Risk model" but essentially it's also something like a sitemap, table of content, link-collection, ...

and the mouse-over text could include a hint to "click for more information" next to the number of matched rules.

vletoux commented 1 year ago

I cannot accept this PR because the UI design change but the changes have been pushed with other commits

vletoux commented 1 year ago

Ok simply changed css: image

pointer is now more visible