Fixed workflow - Githubissues

netz98 / n98-magerun

The swiss army knife for Magento developers, sysadmins and devops. The tool provides a huge set of well tested command line commands which save hours of work time. All commands are extendable by a module API.

http://magerun.net/

Other

1.44k stars 401 forks source link

Fixed workflow #1430

Closed sreichel closed 2 months ago

sreichel commented 2 months ago

Magerun pull-request check-list:

[x] Pull request against develop branch (if not, just close and create a new one against it)
[x] README.md reflects changes (if any)

Fixes broken workflow for v.20.1+

cmuench commented 2 months ago

@sreichel Great! Looks like you fixed the technical issue of the ci pipeline. And we found some new issues with PHP 8.2 by running the tests. :+1:

sreichel commented 2 months ago

@cmuench i dont think its only related to php8.2 ... see linked issue.

cmuench commented 2 months ago

@cmuench i dont think its related to php8.2 ... see linked issue.

@sreichel If the issue is in OpenMage then it's nice that we could find this here. IMHO we can merge the changes here to develop branch and then wait for a fix in MageOS ... and then update the CI config to install the fixed versions. What do you mean?

sreichel commented 2 months ago

@cmuench merging to develop should be okay. Maybe you want to test install-command in local environment before. Maybe i've missed something.

cmuench commented 2 months ago

@sreichel LGTM