search

netz98 / n98-magerun

The swiss army knife for Magento developers, sysadmins and devops. The tool provides a huge set of well tested command line commands which save hours of work time. All commands are extendable by a module API.
http://magerun.net/
Other
1.44k stars 400 forks source link

Removed Magento 2 code #1462

Closed sreichel closed 2 months ago

sreichel commented 2 months ago

Magerun pull-request check-list:

Changes proposed in this pull request:

sreichel commented 2 months ago

I have some tests that fail locally like ...

1) N98\Magento\Command\System\Setup\RemoveCommandTest::testRemoveModule
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "Mage_Core_Model_Resource" does not exist

/var/www/html/tests/N98/Magento/Command/System/Setup/RemoveCommandTest.php:27

2) N98\Magento\Command\System\Setup\RemoveCommandTest::testRemoveBySetupName
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "\Mage_Core_Model_Resource" does not exist

/var/www/html/tests/N98/Magento/Command/System/Setup/RemoveCommandTest.php:65

3) N98\Magento\Command\System\Setup\RemoveCommandTest::testRemoveBySetupNameFailure
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "\Mage_Core_Model_Resource" does not exist

/var/www/html/tests/N98/Magento/Command/System/Setup/RemoveCommandTest.php:107

... but they fail on current develop branch too?

sreichel commented 2 months ago

Merged ... to make some progess. Everything else in a final review.