Fix Keycloak errors caused by SMS 2FA

[svenseeberg]

With this plugin enabled, we experience an increased rate of Keycloak errors. We need to investigate if this is caused by Keycloak itself or this plugin.

There are 2 errors that seem to be related to activating the "Force 2FA" function:

• https://github.com/keycloak/keycloak/issues/15656
• LDAP Federation Provider sync errors (2022-11-28 14:01:03,783 WARN [org.keycloak.storage.ldap.LDAPStorageProviderFactory] (Timer-0) User with ID 'XXX' is not updated during sync as he already exists in Keycloak database but is not linked to federation provider 'myldap') It seems that this is unrelated.

The error rate is strongly increasing with the feature activated. But it seems there are other causes as well. We should try to answer the following questions:

• Are there other parts in the SMS 2FA plugin that trigger these errors?
• Is the SMS 2FA plugin using Keycloak classes/methods incorrectly or are these actually Keycloak errors?

[svenseeberg]

I'll keep the ticket open until we've confirmed that this fixes the issue.

One addition: I'm quite confident that our data now confirms that the error rate goes up with the Force 2FA function increases the error rate. On days we activate the function, we have about 4 times more errors than on days without. We toggled this for 3 times and it consistently changes the error rate.