search

netzke / netzke-core

Framework for Sencha Ext JS + Ruby on Rails client-server components
http://netzke.org
Other
263 stars 77 forks source link

undefined method `current_user' for Netzke::Core:Module #54

Closed scho closed 11 years ago

scho commented 11 years ago

Hi folks, I tried to upgrade our existing netzke app from 0.7.7 to 0.8.1 today. And somehow netzke got rid of the very handy Netzke::Core.current_user helper. Did it get lost with the 0.8 upgrade or is this intentional?

Also netzke-cancan assumes, that this method ist present.

If people should use Netzke::Base.controller.current_user, then this issue can be closed.

mxgrn commented 11 years ago

It was removed in order to decrease coupling with ActiveController and with the way current_user (which could be named anything) is being defined on ApplicationController. It's fine to use Netzke::Base.controller.current_user - netzke-cancan should probably rely on it.

scho commented 11 years ago

I updated netzke-cancan and I stuck to the netzke versioning.

The latest version of netzke-cancan works with the latest netzke-core version.

Everyone, who is on ~> 0.7.0 of netzke-core should use the corresponding version (~> 0.7.0) of netzke-cancan.

I've also updated the readme.