netzke / netzke-core

Framework for Sencha Ext JS + Ruby on Rails client-server components
http://netzke.org
Other
263 stars 77 forks source link

Also check for icons in the assets. #72

Closed nathanvda closed 10 years ago

nathanvda commented 10 years ago

Netzke now uses assets/icons as the default path to find the icons, so we need to look for the icons in the asset-folders. Since the icons are supplied by a vendor, I place those generally in vendor/assets so for completeness check all asset paths.

This will still fail if the icons are bundled in a asset gem.

I can still clean up the code a bit, and add tests, but I needed this code myself when I moved my icons from public/images/icons to vendors/assets/images/icons. All the action-columns worked, but the buttons in toolbars suddenly lost their icons.

This change fixes that.

mxgrn commented 10 years ago

This has been recently fixed in master using more solid find_asset: c0a7e4f2f6177654d1e4cc3b666a4f41c551912a