netzke / netzke-core

Framework for Sencha Ext JS + Ruby on Rails client-server components
http://netzke.org
Other
263 stars 77 forks source link

ExtJS 6 support (switchable via parameter) #83

Closed Mahaswami closed 7 years ago

Mahaswami commented 8 years ago

Backward compatible with ExtJS 5.1. Unless there is a major set of breaking changes it is probably a good idea to support both versions using the same code base purely from a technical standpoint.

mxgrn commented 8 years ago

Unless there is a major set of breaking changes it is probably a good idea to support both versions

This may sound like a good idea until it becomes a horrible mess of the if statements. I can almost guarantee there will be more of those than you initially expect. That's why I choose to keep a separate branch for older Ext JS versions and backport the fixes from master. Let me know what you think.