netzkolchose / django-fast-update

Faster db updates using UPDATE FROM VALUES sql variants.
MIT License
20 stars 2 forks source link

manager vs. (filtered) queryset in fast_update #20

Open jerch opened 1 year ago

jerch commented 1 year ago

There is a possible incongruency in fast_update (and copy_update), if the method gets called on a prefiltered queryset:

This may lead to a partial update only for prefiltered rows.

Needs some tests about the actual behavior of bulk_update under various qs conditions, then fast_update should reflect that behavior. Also check, if fast.fast_update should support a manager as first argument.