neu-rah / ArduinoMenu

Arduino generic menu/interactivity system
GNU Lesser General Public License v2.1
948 stars 191 forks source link

BUG, The display doesn't change when changing (press rotary encoder) submenu of the toggle #352

Closed kapete23 closed 3 years ago

kapete23 commented 3 years ago

Hello Sir, there is a bug in the 2002 LCD display. The display does not change when changing (press rotary encoder) submenu of the toggle. If on a serial monitor, that's normal.

I am using Arduino Mega.

This is the display on the serial monitor: https://user-images.githubusercontent.com/42960459/114934921-c1300500-9e64-11eb-83ed-85d4f60d3e92.mp4

But that's not normal on LCD2002, the display doesn't change.

This is the display on LCD 2002: https://user-images.githubusercontent.com/42960459/114977967-c4ea7880-9eb2-11eb-9d55-03c04fb27c4c.mp4

The display changes when the cursor moves

neu-rah commented 3 years ago

hi! it looks like and encoder issue (I mean, if lcd also moves when using serial), can you show your menu input definition?

looking at the video... be sure to define a panel that corresponds to your LCD dimensions... can we see your output definiton?

kapete23 commented 3 years ago

I apologize for taking this as a BUG, after studying your library the problem is found here.

nav.target-> dirty = true;

I put that into the function, and it got solved

this is my output definition :

LiquidCrystal lcd(22, 24, 26, 2, 28, 3);

MENU_OUTPUTS(out,MAX_DEPTH ,SERIAL_OUT(Serial) ,LIQUIDCRYSTAL_OUT(lcd,{0,0,20,2}) );

Thanks for the feedback :)