neu-vi / OmniControl

OmniControl: Control Any Joint at Any Time for Human Motion Generation, ICLR 2024
https://neu-vi.github.io/omnicontrol/
MIT License
243 stars 17 forks source link

Discrepancy in skating ratio: HumanML3D dataset vs. OmniControl results #22

Open QingYuan-L opened 1 month ago

QingYuan-L commented 1 month ago

Dear Authors,

While working with OmniControl, I've noticed some issues regarding the skating ratio that I'd like to bring to your attention:

1.Skating ratio in the HumanML3D dataset:

2.Skating ratio in OmniControl generated results:

3.Skating ratio calculation method:

ymingxie commented 1 month ago

Hi Qingyuan,

Thanks for asking. The Ground Truth motion is not perfect so it's reasonable to have foot skating. A better way might be also show the GT skating ratio in the table as a reference.

It's also possible that the predicted motion has a lower skating ratio or even lower FID than Ground Truth as the GT motion sequences are captured using some mocap methods that aren't flawless and may contain some errors.

Our calculation method exactly follows GMD code (https://github.com/korrawe/guided-motion-diffusion/blob/main/data_loaders/humanml/utils/metrics.py#L204). Not sure if it includes issues like clipping. As far as I know, there are no other public code scripts that can calculate the skating ratio.

Thanks