Open tkkcc opened 3 months ago
DefaultPredictor of detectron2_modify, only disable parameters grad, but remain model in training, this cause wrong logic when using Mask2Former as criterion.
solution: restore the model.eval() as in original detectron2: https://github.com/facebookresearch/detectron2/blob/0ae803b1449cd2d3f8fa1b7c0f59356db10b3083/detectron2/engine/defaults.py#L280-L285
model.eval()
another bug: it's loading the first char of a path string https://github.com/neu-vi/SportsSloMo/blob/78f31a950e3ea57a5607add1f7144179c8d0fab8/SportsSloMo_EBME/core/dataset.py#L186-L187 solution: remove [0]
[0]
other problems: the readme says pip install -e to install detectron2, this will make our own tools unable to import. for now, need to use this pr https://github.com/facebookresearch/detectron2/pull/5283
pip install -e
detectron2
tools
there is also missing symbol link of Mask2Former in SportsSloMo_EBME, it's no said in readme, neither tracked in git repo.
the shell command in readme is not perfect, it's common that command needs to be run in parent or sub dir.
DefaultPredictor of detectron2_modify, only disable parameters grad, but remain model in training, this cause wrong logic when using Mask2Former as criterion.
solution: restore the
model.eval()
as in original detectron2: https://github.com/facebookresearch/detectron2/blob/0ae803b1449cd2d3f8fa1b7c0f59356db10b3083/detectron2/engine/defaults.py#L280-L285another bug: it's loading the first char of a path string https://github.com/neu-vi/SportsSloMo/blob/78f31a950e3ea57a5607add1f7144179c8d0fab8/SportsSloMo_EBME/core/dataset.py#L186-L187 solution: remove
[0]
other problems: the readme says
pip install -e
to installdetectron2
, this will make our owntools
unable to import. for now, need to use this pr https://github.com/facebookresearch/detectron2/pull/5283there is also missing symbol link of Mask2Former in SportsSloMo_EBME, it's no said in readme, neither tracked in git repo.
the shell command in readme is not perfect, it's common that command needs to be run in parent or sub dir.