search

neu-vi / SportsSloMo

SportsSloMo: A New Benchmark and Baseline Models for Human-centric Video Frame Interpolation, CVPR 2024 (https://arxiv.org/abs/2308.16876)
https://neu-vi.github.io/SportsSlomo/
64 stars 3 forks source link

missing eval in DefaultPredictor of detectron2_modify #10

Open tkkcc opened 3 months ago

tkkcc commented 3 months ago

DefaultPredictor of detectron2_modify, only disable parameters grad, but remain model in training, this cause wrong logic when using Mask2Former as criterion.

solution: restore the model.eval() as in original detectron2: https://github.com/facebookresearch/detectron2/blob/0ae803b1449cd2d3f8fa1b7c0f59356db10b3083/detectron2/engine/defaults.py#L280-L285

another bug: it's loading the first char of a path string https://github.com/neu-vi/SportsSloMo/blob/78f31a950e3ea57a5607add1f7144179c8d0fab8/SportsSloMo_EBME/core/dataset.py#L186-L187 solution: remove [0]

other problems: the readme says pip install -e to install detectron2, this will make our own tools unable to import. for now, need to use this pr https://github.com/facebookresearch/detectron2/pull/5283

there is also missing symbol link of Mask2Former in SportsSloMo_EBME, it's no said in readme, neither tracked in git repo.

the shell command in readme is not perfect, it's common that command needs to be run in parent or sub dir.