search

neuecc / LINQ-to-BigQuery

LINQ to BigQuery is C# LINQ Provider for Google BigQuery. It also enables Desktop GUI Client with LINQPad and plug-in driver.
MIT License
86 stars 16 forks source link

Issue with dutch number formats. #29

Closed greigs closed 10 years ago

greigs commented 10 years ago

I encountered an issue with FormatExceptions appearing when running on a server with the system region format set to Dutch (Netherlands). This is because they use a comma for instead of a decimal point in their numbers. This also affects dates because of the way they converted to unix style longs.

Some of the unit tests break as a result. To recreate, switch your system "region and language" formats to Dutch (Netherlands) then run the unit tests.

I have solved the issue in my forked branch. The relevant commit is here: https://github.com/greigs/LINQ-to-BigQuery/commit/0745929b4306a3767f923ae066b2b89c8122a6f1

I hope you can include these changes in the next release.

Thanks, Greig

neuecc commented 10 years ago

Thanks!

I did not know it! I'll merge it.

neuecc commented 10 years ago

Now, I've uploaded 0.5.0 to NuGet that contains your great fixes!

Thank you very much.

greigs commented 10 years ago

Excellent! Glad to help.