search

neuecc / Utf8Json

Definitely Fastest and Zero Allocation JSON Serializer for C#(NET, .NET Core, Unity, Xamarin).
MIT License
2.36k stars 267 forks source link

PrimitiveObjectFormatter List <string> No comma is output by Serialize. #61

Open t-niijima-adglobe-co-jp opened 6 years ago

t-niijima-adglobe-co-jp commented 6 years ago

Hi. Thanks for this very nice lib. When serializing List with PrimitiveObjectFormatter, I noticed that no comma was output. When I looked at the code, I found that the PrimitiveObjectFormatter didn't increment the "count" variable to write the separator : https://github.com/neuecc/Utf8Json/blob/master/src/Utf8Json/Formatters/PrimitiveObjectFormatter.cs#L95 Isn't it necessary ?

neuecc commented 6 years ago

Thank you! Yes, it is a bug, I should fix it!

t-niijima-adglobe-co-jp commented 6 years ago

Thank you! Closing this.

neuecc commented 6 years ago

Thanks for confirm, but this is not yet released. I'll release soon and if released, i'll close this.