neueda / jetbrains-plugin-graph-database-support

Graph Databases support for JetBrains family IDEs.
Apache License 2.0
221 stars 56 forks source link

when applied database.api + database.neo4j will contain OSGi Manifests #14

Closed CrystalMethod closed 7 years ago

CrystalMethod commented 7 years ago

I would like to reuse the database.* projects (currently database.api + database.neo4j) in an OSGi environment. I'm not an Gradle expert, so please verify the setup. Additional I added a plugin to install the artifacts into local Maven repository.

FylmTM commented 7 years ago

Hi @CrystalMethod,

Can you share a bit more details on expected usage? I have considered those modules to be plugin-specific and going to change them quite a bit somewhere in near future.

CrystalMethod commented 7 years ago

The database module and its submodules aren't plugin-specific (as far as I understood); its a generic wrapper for specific graphdb backends (Neo4j for now). I would like to use this wrapper and backend specific adapter(s) in an OSGi environment (Eclipse/Eclipse-Plugins).

That's why I skipped jetbrains.plugin part for the Bundle-SymbolicName (https://github.com/neueda/jetbrains-plugin-graph-database-support/pull/14/commits/bab512e27ee03e89df59e1b55b5f84733f166708#diff-d4d09088453f18cd3070fb52c5aaf83cR28)

FylmTM commented 7 years ago

Unfortunately I believe that plugin should not contain non-plugin specific code.