neueda / jetbrains-plugin-graph-database-support

Graph Databases support for JetBrains family IDEs.
Apache License 2.0
221 stars 56 forks source link

File context menu #43

Closed Vorago closed 7 years ago

Vorago commented 7 years ago

This change is Reviewable

FylmTM commented 7 years ago

Review status: 0 of 11 files reviewed at latest revision, 4 unresolved discussions.


database/neo4j/src/main/java/com/neueda/jetbrains/plugin/graphdb/database/neo4j/bolt/Neo4jBoltDatabase.java, line 78 at r1 (raw file):


            long startTime = System.currentTimeMillis();
            StatementResult statementResult = null;

Should consume result


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/ExecuteAllAction.java, line 51 at r1 (raw file):

ues("Andrew"); else { Notification.error() }


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/StatementCollector.java, line 67 at r1 (raw file):

//TODO fixme. Avoid DoS'ing messageBus Maybe delete?


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/database/QueryExecutionService.java, line 71 at r1 (raw file):

String query = payload.getQueries().get(0); Put a if for 1 element


Comments from Reviewable

FylmTM commented 7 years ago

Reviewed 7 of 11 files at r1, 4 of 4 files at r2. Review status: all files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

FylmTM commented 7 years ago
:lgtm:

Review status: all files reviewed at latest revision, 4 unresolved discussions.


Comments from Reviewable

FylmTM commented 7 years ago

Review status: all files reviewed at latest revision, 4 unresolved discussions.


database/neo4j/src/main/java/com/neueda/jetbrains/plugin/graphdb/database/neo4j/bolt/Neo4jBoltDatabase.java, line 78 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…
Should consume result

ok


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/ExecuteAllAction.java, line 51 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…
> ues("Andrew"); else { Notification.error() }

ok


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/actions/execute/StatementCollector.java, line 67 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…
> //TODO fixme. Avoid DoS'ing messageBus Maybe delete?

ok


ui/jetbrains/src/main/java/com/neueda/jetbrains/plugin/graphdb/jetbrains/database/QueryExecutionService.java, line 71 at r1 (raw file):

Previously, FylmTM (Dmitrijs Vrublevskis) wrote…
> String query = payload.getQueries().get(0); Put a if for 1 element

ok


Comments from Reviewable