neuefische / web-exercises

Session exercises
MIT License
20 stars 33 forks source link

Css Selectors Demo #259

Closed ahohnsen closed 1 year ago

ahohnsen commented 1 year ago

Updated demo:

❓ Open questions/suggestions:

Let me know, what you think πŸ™‚

css-selectors/demo-start

πŸ“„ Rendered Exercise

πŸ”Ž Review

Review via πŸ”— CodeSandbox or locally by running this command in your Terminal:

npx ghcd@latest neuefische/web-exercises/tree/css-selectors-demo/sessions/css-selectors/demo-start -i

css-selectors/demo-end

πŸ“„ Rendered Exercise

πŸ”Ž Review

Review via πŸ”— CodeSandbox or locally by running this command in your Terminal:

npx ghcd@latest neuefische/web-exercises/tree/css-selectors-demo/sessions/css-selectors/demo-end -i
PReichetanz commented 1 year ago

❓ Open questions/suggestions:

The combinators are part of the demo but not of the session guide. I suggest to add a short section in the session guide for combinators if we teach them during this session.

Yes, I agree that the session guide should mirror the demo and help coaches to teach the session.

The session guide shows different code examples for the selectors than the demo. I would propose to rewrite the session guide, so you can follow along the demo with the guide (as for example in the js-conditions-and-booleans session.

This should be changed as well. Should we create an issue to tackle this?

ahohnsen commented 1 year ago

❓ Open questions/suggestions:

The combinators are part of the demo but not of the session guide. I suggest to add a short section in the session guide for combinators if we teach them during this session.

Yes, I agree that the session guide should mirror the demo and help coaches to teach the session.

The session guide shows different code examples for the selectors than the demo. I would propose to rewrite the session guide, so you can follow along the demo with the guide (as for example in the js-conditions-and-booleans session.

This should be changed as well. Should we create an issue to tackle this?

Yes, sounds good! πŸ™ŒπŸΌ