Closed ahohnsen closed 1 year ago
β Open questions/suggestions:
The combinators are part of the demo but not of the session guide. I suggest to add a short section in the session guide for combinators if we teach them during this session.
Yes, I agree that the session guide should mirror the demo and help coaches to teach the session.
The session guide shows different code examples for the selectors than the demo. I would propose to rewrite the session guide, so you can follow along the demo with the guide (as for example in the js-conditions-and-booleans session.
This should be changed as well. Should we create an issue to tackle this?
β Open questions/suggestions:
The combinators are part of the demo but not of the session guide. I suggest to add a short section in the session guide for combinators if we teach them during this session.
Yes, I agree that the session guide should mirror the demo and help coaches to teach the session.
The session guide shows different code examples for the selectors than the demo. I would propose to rewrite the session guide, so you can follow along the demo with the guide (as for example in the js-conditions-and-booleans session.
This should be changed as well. Should we create an issue to tackle this?
Yes, sounds good! ππΌ
Updated demo:
:root
selector including all CSS variables and used color names instead ππΌ The:root
selector is actually part of the css-structure session, so I would keep this demo a bit more simpleβ Open questions/suggestions:
Let me know, what you think π
css-selectors/demo-start
π Rendered Exercise
π Review
Review via π CodeSandbox or locally by running this command in your Terminal:
css-selectors/demo-end
π Rendered Exercise
π Review
Review via π CodeSandbox or locally by running this command in your Terminal: