Fixes issue where messages are not built before they are used

neufieldrobotics / spinnaker_sdk_camera_driver

Point Grey (FLIR) Spinnaker based camera driver (Blackfly S etc.)

MIT License

125 stars 90 forks source link

Fixes issue where messages are not built before they are used #11

Closed ebretl closed 5 years ago

ebretl commented 5 years ago

Fixes #7 better than just recompiling several times. Gencpp and genpy were not used as components

ghost commented 5 years ago

@ebretl thanks for looking into this, I have been trying to sort this for a while. I tried your changes, but didn't seem to make much difference in the outcome, I still can't compile in the first try. I see you added genpy and gencpp, but those didn't make much difference since they are already dependencies of message_generation. I have no idea what the issue is.

remod commented 5 years ago

I think the best practice is to create a separate _msgs package, and let the driver depend on it. When creating another package which needs these messages (e.g. a user interface), it does not need to depend on the driver itself but only on the message package.

JWhitleyWork commented 5 years ago

@ebretl / @shahvi - See my PR #14. It includes the fix for #7 in the currently-accepted way (gencpp and genpy are deprecated).