Statements inside ROS_ASSERT_MSG are not run in release mode

neufieldrobotics / spinnaker_sdk_camera_driver

Point Grey (FLIR) Spinnaker based camera driver (Blackfly S etc.)

MIT License

125 stars 91 forks source link

Statements inside ROS_ASSERT_MSG are not run in release mode #141

Closed ghost closed 2 years ago

ghost commented 2 years ago

When compiling in release mode (catkin_make -DCMAKE_BUILD_TYPE=Release), several ROS_ASSERT_MSG statements are not executed. This causes camera initialisation to fail and the relevant messages are not displayed. This PR moves statements which set variables outside of the ROS_ASSERT_MSG statements.

ghost commented 2 years ago

Fixes #80

vik748 commented 2 years ago

@calum-blair-archangel Thanks for taking this on. We only merge from dev into master. Can you please rebase this pull request to merge into dev.

ghost commented 2 years ago

@vik748 thanks, I've updated the branch and rebased