search

neufieldrobotics / spinnaker_sdk_camera_driver

Point Grey (FLIR) Spinnaker based camera driver (Blackfly S etc.)
MIT License
127 stars 90 forks source link

Feature/ubuntu 20.4 #151

Open PushyamiKaveti opened 2 years ago

PushyamiKaveti commented 2 years ago

@mithundiddi @jpsnir Please review and merge. OpenCV update for ubuntu 20.04

vik748 commented 2 years ago

Why is the CI failing, it should continue working with the old versions right?

PushyamiKaveti commented 2 years ago

Not sure, Re-running the build.

PushyamiKaveti commented 2 years ago

Found the issue, it is failing because travis build is happening for ubuntu < 20.04 with opencv 3.2.0 and this branch is particularly for opencv 4.x and ubuntu 20.04. We have to setup build for this configuration.

vik748 commented 2 years ago

One thought, all these ifdefs make it really hard to read the code. How about we reaname all the calls to the new open cv functions. Then in one place do a OpenCV version check and then assign function aliases to the old opencv functions if needed. This way there should only be 1 if def. Aliases: https://www.fluentcpp.com/2017/10/27/function-aliases-cpp/

vik748 commented 2 years ago

@PushyamiKaveti @mithundiddi this should fix the issue building. Please try it out once.