search

neugram / ng

scripting language integrated with Go
https://neugram.io
BSD 2-Clause "Simplified" License
917 stars 43 forks source link

implement naked returns #189

Closed sbinet closed 6 years ago

sbinet commented 6 years ago

Fixes neugram/ng#188.

codecov-io commented 6 years ago

Codecov Report

Merging #189 into master will decrease coverage by 0.01%. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   50.54%   50.53%   -0.02%     
==========================================
  Files          22       22              
  Lines       10016    10025       +9     
==========================================
+ Hits         5063     5066       +3     
- Misses       4452     4458       +6     
  Partials      501      501
Impacted Files Coverage Δ
typecheck/typecheck.go 22.4% <28.57%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cce5c9e...a51db59. Read the comment docs.

sbinet commented 6 years ago

I started with only passing the len of the slice, but for detecting when there is shadowing, I'll probably need to get the names of the variable too.

crawshaw commented 6 years ago

OK, sounds good.