neugram / ng

scripting language integrated with Go
https://neugram.io
BSD 2-Clause "Simplified" License
916 stars 43 forks source link

eval,parser: implement binary-| eval #202

Closed sbinet closed 6 years ago

sbinet commented 6 years ago

Fixes neugram/ng#196.

codecov-io commented 6 years ago

Codecov Report

Merging #202 into master will decrease coverage by 0.46%. The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   50.79%   50.33%   -0.47%     
==========================================
  Files          22       22              
  Lines       10174    10252      +78     
==========================================
- Hits         5168     5160       -8     
- Misses       4504     4588      +84     
- Partials      502      504       +2
Impacted Files Coverage Δ
format/expr.go 48.16% <0%> (-4.45%) :arrow_down:
format/tipe.go 69.59% <0%> (-1.72%) :arrow_down:
eval/op.go 30.22% <11.53%> (-1.38%) :arrow_down:
parser/scanner.go 66.93% <0%> (-2.2%) :arrow_down:
parser/parser.go 70.05% <0%> (-0.22%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f923ea...40c353a. Read the comment docs.

sbinet commented 6 years ago

I've rebased this PR on top of #213 (so as to not disable then re-enable the TableLiteral typecheck test.) PTAL.

crawshaw commented 6 years ago

LGTM