neuhalje / bouncy-gpg

Make using Bouncy Castle with OpenPGP fun again!
https://neuhalje.github.io/bouncy-gpg/
Other
205 stars 58 forks source link

Writing Keyrings to storage #21

Closed vanitasvitae closed 5 years ago

vanitasvitae commented 6 years ago

Hi! I noticed, that Bouncy-GPG for now only focusses on reading keyrings from files etc. Is support for writing modified keyrings planned as well?

neuhalje commented 6 years ago

I ain't not dead yet :-) .... just a lot of "real world TODOs" .... nothing is really planed, I go on a "what the users need" base

vanitasvitae commented 6 years ago

Just for the record: I decided to create my own library due to limited time and me constantly breaking your test cases :laughing:. I'm following a similar pattern as your library though, so you might still be able to pick some of my code and port it to bouncy-gpg :)

neuhalje commented 6 years ago

You are welcome! Copy as much as you want — that ist what FOSS is for! 😊

On 19. Jun 2018, at 20:57, Paul Schaub notifications@github.com wrote:

Just for the record: I decided to create my own library due to limited time and me constantly breaking your test cases 😆. I'm following a similar pattern as your library though, so you might still be able to pick some of my code and port it to bouncy-gpg :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

vanitasvitae commented 6 years ago

Copy as much as you want — that ist what FOSS is for! :blush:

Same for you obviously :)

jrobens commented 5 years ago

Is this about the gpg2 secret key format where the keys are stored in private-keys-v1.d directory in individual files or reading from some secrets provider, sql, nosql etc provider? I'm interested in both, but gpg2 format first.

neuhalje commented 5 years ago

@jrobens Haven't decided yet - depends on what BouncyCastle provides for this

@vanitasvitae : What does your implementation support?

vanitasvitae commented 5 years ago

PGPainless currently has no real API for writing keys. If a user wants to write keys/keyrings to file, they must use the BC methods for now. Still, creating a simple API for writing is definitely something on my TODO list.

neuhalje commented 5 years ago

@jrobens storing keys in a store of your own application is recommended. I wrote a reasoning for why using gpgs storage is most likely not the best course of action.

jrobens commented 5 years ago

@neuhalje in-memory-keyring suits our use. The in-memory-keyring is highly flexible with a useful api.

neuhalje commented 5 years ago

@jrobens : Thanks!