search

neuhalje / bouncy-gpg

Make using Bouncy Castle with OpenPGP fun again!
https://neuhalje.github.io/bouncy-gpg/
Other
205 stars 58 forks source link

fixed message at successful validated signature #36

Closed user9209 closed 4 years ago

user9209 commented 4 years ago

If "Successful validated signature" is true, there should be no "because we have no matching public key". See: https://github.com/neuhalje/bouncy-gpg/blob/f11eae65068afd94dd5eccbdb0cd1bb8ab5f5f0b/src/main/java/name/neuhalfen/projects/crypto/bouncycastle/openpgp/validation/SignatureValidationHelper.java#L33

I was very confused because I always get that message:

Actual:

DEBUG name.neuhalfen.projects.crypto.bouncycastle.openpgp.validation.SignatureValidationHelper - Successful validated signature with key 0x... because we have no matching public key

First it has looked like an optional signature evaluation.

Expected:

DEBUG name.neuhalfen.projects.crypto.bouncycastle.openpgp.validation.SignatureValidationHelper - Successful validated signature with key 0x...

Seems to be a copy of https://github.com/neuhalje/bouncy-gpg/blob/f11eae65068afd94dd5eccbdb0cd1bb8ab5f5f0b/src/main/java/name/neuhalfen/projects/crypto/bouncycastle/openpgp/validation/SignatureValidationHelper.java#L39

neuhalje commented 4 years ago

Thanks for the PR! I would be confused as well.