neuhalje / bouncy-gpg

Make using Bouncy Castle with OpenPGP fun again!
https://neuhalje.github.io/bouncy-gpg/
Other
205 stars 58 forks source link

Added the MDC verification code #54

Closed Sauhardstark closed 4 years ago

Sauhardstark commented 4 years ago
Sauhardstark commented 4 years ago

Addresses the issue #45

Sauhardstark commented 4 years ago

@neuhalje Can you please rake a look

neuhalje commented 4 years ago

At a first glance this looks good. In the Test we should comment where the magic 595 came from.

I suggest that you comment that and squash the commit. I’ll be back to the keyboard this evening.

I was thinking of rewriting the two stream wrappers with an observable stream and two listeners for the close event as a next step. What is your opinion on that?

Slightly unrelated: Also I am planning to switch from throwing IOEcxeptions to introducing some kind of „Logging“ object where we can protocol e.g. the signatures checked, the keys used and the errors encountered. How does that sound?

EDIT: formatting

Sauhardstark commented 4 years ago

@neuhalje I'll write the comments regarding the 595 bit The stream wrapper to observable stream sounds great as that will be easier to scale if new changes come. Regarding the Logging object, I'm not sure I entirely understand what the proposed change is (like is the Logging object a custom POJO that contains placeholders for data, exceptions etc ?)

Sauhardstark commented 4 years ago

@neuhalje any updates on the above please ?

neuhalje commented 4 years ago

My bad - I did not see your latest commit! This afternoon I'll merge and also look a the others. Thank you very much, If you'd like to, we can tackle a few other things as well

Sauhardstark commented 4 years ago

I've sent you a mail regarding discussing other topics