neulab / ExplainaBoard

Interpretable Evaluation for AI Systems
MIT License
359 stars 36 forks source link

Remove additional config argument from Metric #512

Closed odashi closed 1 year ago

odashi commented 1 year ago

This change removes config arguments from methods in Metric.

Overall, this argument is rarely utilized while it is not referred appropriately in many subclasses. Since we can instantiate another Metric object to use different configs, I thought that we can remove this argument without any drawbacks.

This pull request also contains some typing errors in Metric classes.

odashi commented 1 year ago

@neubig I think we should implement some inner singleton to hold sharable objects between the same metric instead of overriding the config.

neubig commented 1 year ago

Sounds good, I'd suggest we revisit that if when it becomes necessary.