Remove MetricResult.config.

neulab / ExplainaBoard

Interpretable Evaluation for AI Systems

MIT License

359 stars 36 forks source link

Remove MetricResult.config. #513

Closed odashi closed 1 year ago

odashi commented 1 year ago

Related to #491

This change removes MetricResult.config. This member is not used at this point, and we basically don't need to store the same config in this struct because we can obtain the same information directly from Metric.

odashi commented 1 year ago

I think MetricConfig (or Metric) should be serialized separately as well. I also think parallel structure is more maintainable than nested structure.

"metric_configs": {
  "foo": <foo_config>,
  "bar": <bar_config>
},
"metric_results": {
  "foo": <foo_result>,
  "bar": <bar_result>
}

neubig commented 1 year ago

OK, sounds good. I'll review this.