Open odashi opened 1 year ago
RFC: @neubig @pfliu-nlp
Sounds like a good idea, I agree
"The most significant abuse around this behavior is that FileLoaderMetadata is implicitly converted into SysOutputInfo."
Agree. Adding system metadata class
sounds nice.
Processor.process()
takesmetadata
, which is used to directly initializeSysOutputInfo
. However, these are essentially different data (especially, "metadata" $\subset$SysOutputInfo
, but not $=$) and the current implementation makes some confusion around this:The most significant abuse around this behavior is that
FileLoaderMetadata
is implicitly converted intoSysOutputInfo
. This shouldn't work unless explicit conversion: https://github.com/neulab/ExplainaBoard/blob/4cec0a01cbe2617e9a67a440be25ee4252f792b2/integration_tests/ner_test.py#L148-L154To this end, we need:
Processor
to take the system metadata, not a dict.FileLoaderReturn
/SysOutputInfo
FileLoaderReturn
/SysOutputInfo