neulab / ExplainaBoard

Interpretable Evaluation for AI Systems

MIT License

360 stars 36 forks source link

Serializable SysOutputInfo #579

Closed odashi closed 1 year ago

odashi commented 1 year ago

Overview

Makes SysOutputInfo serializable. Fixes #446

Details

By applying this change, we can serialize almost everything that the ExplainaBoard generates. Following code is also deleted because it is no longer necessary:

Methods in SysOutputInfo to convert it to dict.
explainaboard/serialization/legacy.py

This PR also fixes several typing bugs around SysOutputInfo that does not match with actual data.

References

Blocked by

odashi commented 1 year ago

@neubig @pfliu-nlp It looks there are some failing tests (due to assertion around t-test), which is unexpected and may be a potential bug around the code, but it is somewhat hard to figure out the reason. Could you take a look at the errors?

odashi commented 1 year ago

@neubig @pfliu-nlp Fixed bugs. Please take a look at the changes.