neulab / explainaboard_client

1 stars 1 forks source link

Failed to delete systems for custom dataset. #21

Closed PaulCCCCCCH closed 1 year ago

PaulCCCCCCH commented 2 years ago

I upload a system with custom dataset using with the following:

python -m explainaboard_client.cli.upload_system \
  --email $EB_EMAIL --api_key $EB_API_KEY \
  --task text-classification \
  --system_name test-cli-1 \
  --system_output /mnt/c/Users/paulc/Desktop/exb-test-systems/multi-classification/pred.tsv \
  --output_file_type text \
  --custom_dataset /mnt/c/Users/paulc/Desktop/exb-test-systems/multi-classification/dataset.tsv \
  --custom_dataset_file_type tsv \
  --source_language en \
  --target_language en \
  --server local

Then I tried to delete it with

python -m explainaboard_client.cli.delete_systems \
  --email $EB_EMAIL \
  --api_key $EB_API_KEY \
  --system_ids 63288597c7cb5738d5b9826b

CLI gives the following error

Traceback (most recent call last):
  File "/home/paul/explainaboard_client/explainaboard_client/cli/delete_systems.py", line 66, in main
    f'dataset={system_dict["system_info"]["dataset_name"]}, '
KeyError: 'dataset_name'
Failed to delete systems

I think some fields do not exist for custom dataset, and these are only for logging purposes. Deleting itself only require a system ID. So to fix it, I think we can simply give a default text for missing fields.

neubig commented 1 year ago

Should be fixed by #23