search

neulab / explainaboard_client

1 stars 1 forks source link

Breaking changes to resolve before upgrading to 0.0.21 #58

Closed OscarWang114 closed 1 year ago

OscarWang114 commented 1 year ago

The changes in PR https://github.com/neulab/explainaboard_web/pull/526 will break the following code: https://github.com/neulab/explainaboard_client/blob/e4ec42991d22327b69952891a8b5750fe27d6c4c/explainaboard_client/cli/evaluate_system.py#L159

We should resolve this when upgrading to API client 0.0.21

lyuyangh commented 1 year ago

Thanks for the discussion! I tested explainaboard_client and I don't think this PR would affect that project. I only changed SystemInfo (the object we cache) in this PR which is only used in POST /systems/analyses. The client uses GET /systems and POST /systems instead so it should still work.

OscarWang114 commented 1 year ago

Closing as it's not relevant anymore.