neulab / explainaboard_web

MIT License
8 stars 2 forks source link

Refactor system table filter and sorter #518

Closed qjiang002 closed 1 year ago

qjiang002 commented 1 year ago

This PR is related to issue #485

Previous filters and sorters

Screen Shot 2022-11-16 at 4 29 11 PM

Refactor: move filter lists and sorter to the system table header

Screen Shot 2022-11-16 at 4 30 34 PM

Screen Shot 2022-11-16 at 4 31 07 PM

Screen Shot 2022-11-16 at 4 32 07 PM

qjiang002 commented 1 year ago

New commit: support search by system and dataset name with a single search bar.

Screen Shot 2022-11-17 at 1 39 06 PM
pfliu-nlp commented 1 year ago

hi, @qjiang002 Cool, thanks for such a fast implementation.

"support search by system and dataset name with a single search bar."

I wonder whether it could work when users just type a system name, such as bert or they must type system:bert? I'm not sure if the latter one is convenient enough.

qjiang002 commented 1 year ago

Now it requires the prefix "system: bert" to search systems. One way to simplify this is to add a dropdown list before the search bar to auto-fill the prefix. WDYT

neubig commented 1 year ago

@qjiang002 : what about if it doesn't start with "system:" or "dataset:" then we allow it to search any field. Would that work?

qjiang002 commented 1 year ago

Thanks @lyuyangh for the detailed suggestions! Here are some of my thoughts to improve the filter/sort function.

[system/dataset]

[sorting]

neubig commented 1 year ago

As for @neubig 's suggestion of searching for system and dataset together, I think users usually want to compare systems using the same methods or using the same datasets, which can be handled by searching by system/dataset/tag separately. Is there any use case that users need to search them together?

I was just thinking that it's easier to type "sst2" than it is to type "dataset:sst2". If we have separate search bars I think that's not really an issue.

lyuyangh commented 1 year ago

@qjiang002 Sounds good! Let's have separate search bars for the dataset and system names. And yeah, I think we can put the sort column selector in the search bar for now. That seems easier to do and it also provides a better user experience. If you want, feel free to split these into multiple PRs.

qjiang002 commented 1 year ago

This PR is closed as it is split into separate PRs #528, #529, #530.