neulab / explainaboard_web

MIT License
8 stars 2 forks source link

highlight submit system button #521

Closed qjiang002 closed 1 year ago

qjiang002 commented 1 year ago

This PR is related to issue #516

If the user hasn't logged in, they will see System page like this. The tooltip is default visible. User can click either 'Log in' button or 'Submit New System' button to log in.

Screen Shot 2022-11-17 at 2 30 15 PM

If the user has logged in, they will see System page like this.

Screen Shot 2022-11-17 at 2 30 36 PM
lyuyangh commented 1 year ago

Thanks, @qjiang002 !

I like how you made the "New" button more visible by making it bigger. I think we should maybe reserve danger (red) buttons for operations that are risky and less frequently used (e.g. delete) though. This is also what antd suggests (doc). WDYT?

qjiang002 commented 1 year ago

Thanks @lyuyangh . I change the color to 'call-to-action' (green) as suggested in the doc.

Screen Shot 2022-11-17 at 4 02 04 PM Screen Shot 2022-11-17 at 4 02 23 PM