search

neulab / explainaboard_web

MIT License
8 stars 2 forks source link

fix BenchmarkDatasetConfig sub_dataset nullable #524

Closed qjiang002 closed 1 year ago

qjiang002 commented 1 year ago

For datasets without sub_dataset, the sub_dataset property should be nullable, otherwise it will raise error when retrieving datasets for benchmark page.

qjiang002 commented 1 year ago

Thanks for fixing this! I think there are a couple of fields that should be marked as nullable as well, but we can save those for a future PR. I’ll also work on it.

I record this in issue #525. Thanks for help.