neulab / prompt2model

prompt2model - Generate Deployable Models from Natural Language Instructions
Apache License 2.0
1.95k stars 173 forks source link

Fix generator progress bar #337

Closed neubig closed 1 year ago

neubig commented 1 year ago

Description

The generator progress bar was broken, making it look like progress was faster than it actually was.

References

Blocked by

zhaochenyang20 commented 1 year ago

I have once encountered this. Just use p.update(len - p.t) fix it 🤔

neubig commented 1 year ago

Yeah, that's basically what this PR does. You can see the diff here: https://github.com/neulab/prompt2model/compare/refactor_dataset_generator..fix_generator_progress_bar

viswavi commented 1 year ago

@neubig do you need to re-merge main into this branch? It says there are 1k lines added which seems wrong from the description of this PR.

neubig commented 1 year ago

This builds of 335 and 336 so they should be reviewed first, but you can also look at the diff that I posted above too