search

neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 32 forks source link

Calender-Page scrolling area is way too long #165

Open FabianSimonGross opened 1 year ago

FabianSimonGross commented 1 year ago

You basically can scroll into Oblivion on /calendar which is not a good user experience.

alexhorn commented 1 year ago

This is because our implementation of the tab control makes all tabs as long at the longest tab. Since react-swipeable-views seems to be deprecated anyway, we should consider replacing it.

M4GNV5 commented 1 year ago

A simple fix would probably be to make all vies empty except the currently active one, should be an easy fix. Is there a way to get the current active tab from a SwipeableTabs instance?

alexhorn commented 1 year ago

@M4GNV5 During the swipe motion two tabs have to be rendered at once, so I'm not sure that will work

M4GNV5 commented 1 year ago

With the new split between /calendar and /events this problem is way less present. Do we even care enough to keep this issue open?

Robert27 commented 1 year ago

You are right. I think we can close the issue as not implemented or mark it as unimportant for now.