search

neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 33 forks source link

Wrong display of current week in food.js #225

Closed Robert27 closed 1 year ago

Robert27 commented 1 year ago

I simulated that there are only three days available at Mensa, like it is the case before vacations. The day selector in food.js now shows Sunday as the first day. In the second example I removed just the data for Thursday.

I think we should always display one week (Mo-Fr) and add error messages for missing days, like "no menu available". So continue to disable the past days entirely, but make missing days clickable with an appropriate error message.

However we could also, as suggested here, still display the past days. But this would require an update of our API and all other applications (Mensa Widget etc.).

Screenshot 2023-03-21 at 12 03 08 Screenshot 2023-03-21 at 12 13 21
BuildmodeOne commented 1 year ago

Screenshot_2023-03-22-07-52-45-18_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Additional bug: Wrong filler days (even though tested and fixed in #224)

Robert27 commented 1 year ago

This bug was fixed in PR #224. It was just not deployed on the server this morning. :)

M4GNV5 commented 1 year ago

I just deployed the dev app. #224 is live now. This is also the reason why i created issue #226