neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 33 forks source link

#231 Improved room suggestions and separate suggestions page #232

Closed BuildmodeOne closed 1 year ago

BuildmodeOne commented 1 year ago

Screenshots:

πŸ€– Generated by Copilot at bdd1e47

Summary

πŸ—ΊοΈπŸ«πŸ’‘

This pull request adds a new feature to the app that allows students to find nearby and available rooms during their breaks. It also updates some existing components to use new hooks and improve the UI. It also includes a Python script and a JSON file that generate and store the room distance data, which are ignored by git. The main files affected are RoomCard.js, RoomMap.js, suggestions.js, and calculate-distances.py.

Walkthrough

Robert27 commented 1 year ago

I really like this new feature, however I think the free rooms item between two days is a bit unnecessary. I suggest that we separate the two days, so end of lecture until evening and morning until the first lecture. Alternatively, we could remove this time period completely.

image
BuildmodeOne commented 1 year ago

I really like this new feature, however I think the free rooms item between two days is a bit unnecessary. I suggest that we separate the two days, so end of lecture until evening and morning until the first lecture. Alternatively, we could remove this time period completely.

image

That's actually not intended and a bug. Will change that :)

(Only the current day is intended)

M4GNV5 commented 1 year ago

The new code looks good, I would be open to merge it like it is. I left a few comments in case you want to improve it, but we are working on redesigning the pre-generated assets anyways (see #216 and #226)