Closed BuildmodeOne closed 1 year ago
I really like this new feature, however I think the free rooms item between two days is a bit unnecessary. I suggest that we separate the two days, so end of lecture until evening and morning until the first lecture. Alternatively, we could remove this time period completely.
I really like this new feature, however I think the free rooms item between two days is a bit unnecessary. I suggest that we separate the two days, so end of lecture until evening and morning until the first lecture. Alternatively, we could remove this time period completely.
That's actually not intended and a bug. Will change that :)
(Only the current day is intended)
The new code looks good, I would be open to merge it like it is. I left a few comments in case you want to improve it, but we are working on redesigning the pre-generated assets anyways (see #216 and #226)
Screenshots:
π€ Generated by Copilot at bdd1e47
Summary
πΊοΈπ«π‘
This pull request adds a new feature to the app that allows students to find nearby and available rooms during their breaks. It also updates some existing components to use new hooks and improve the UI. It also includes a Python script and a JSON file that generate and store the room distance data, which are ignored by git. The main files affected are
RoomCard.js
,RoomMap.js
,suggestions.js
, andcalculate-distances.py
.Walkthrough
RoomMap.js
component to use theuseUserKind
hook and conditionally render a link to the room suggestions page for students only (link, link, link, link)RoomCard.js
component to import and use theroom-distances.json
file and theuseUserKind
hook, and to filter and sort the available rooms by distance and availability (link, link, link)room-distances.json
file (link, link, link)