neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 33 forks source link

✨ show movies from university cinema #337

Closed BuildmodeOne closed 1 year ago

BuildmodeOne commented 1 year ago

Because the University Cinema doesn't update its website, I used a static JSON file. Source

localhost_3000_events_(iPhone 12 Pro)

🤖 Generated by Copilot at 4804fb1

Summary

🎬📝🎭

The pull request adds cinema events to the cultural events API, using a new movies.json file and the OMDB API. It also fixes some club names in clubs.json that had typos.

We are the rebels of the night We watch the movies of our fight We fix the clubs with no remorse We use the OMDB as our source

Walkthrough

BuildmodeOne commented 1 year ago

Since the movies JSON is static itself, wouldn't it make sense to also embed movie metadata in this JSON file? You can add a new script for retrieving those if you want. That way the events load faster and do not require yet another API key

Makes total sense! Maybe in the future when the university Cinema updates their Website and we scrape it, we can use the API :)

FabianSimonGross commented 1 year ago

Just a Information for you guys, the Uni-Cinema actually adds to the Campus-Life Newsletter, so it should be covered by the normal System. If they don't do it deal with it please like a club that does not add their events to the calender

M4GNV5 commented 1 year ago

Just a Information for you guys, the Uni-Cinema actually adds to the Campus-Life Newsletter, so it should be covered by the normal System. If they don't do it deal with it please like a club that does not add their events to the calender

With the information from moodle (campus life newsletter) we do not get movie metadata. Should we therefore manually filter out cinema events from the data from moodle?

Robert27 commented 1 year ago

Is the pull request still necessary at all, since the first movie is now listed in Moodle / the api?

IMG_2218

BuildmodeOne commented 1 year ago

Is the pull request still necessary at all, since the first movie is now listed in Moodle / the api?

IMG_2218

Just saw this as well. In addition to that yesterday (16.10) they showed "Forest Gump" instead of "Dune" although it was initially announced. They definitely need to improve their communication and until that it probably does not make much sense to implement such a feature.