neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 33 forks source link

Fix/Improve Mensa dish allergene parsing #350

Open M4GNV5 opened 11 months ago

M4GNV5 commented 11 months ago

Describe the bug Currently some allergene descriptions are parsed incorrectly and/or non-allergene declarations are parsed as allergenes.

To Reproduce Compare https://www.max-manager.de/daten-extern/sw-erlangen-nuernberg/xml/mensa-ingolstadt.xml to https://dev.neuland.app/de/food/

Currently e.g.: Gemüsesuppe ( So) mit Brötchen (Wz) turns into Gemüsesuppe ) mit Brötchen and the So allergene is even dropped / not included in our app

Expected behavior Only known allergenes should be parsed, none should be dropped. Non-known (which probably never occurs, except in false positives) can remain in the name

Screenshots image

Additional context