neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 31 forks source link

🚸 show all allergens by default #379

Closed BuildmodeOne closed 9 months ago

BuildmodeOne commented 9 months ago

localhost_3000_de_food_(iPhone 14 Pro Max)

πŸ€–[deprecated] Generated by Copilot at 29bb69c

Summary

πŸ½οΈπŸ§‘β€πŸ³πŸš«

This pull request adds new features and improvements to the food page of the neuland.app project. It implements filtering and matching functions for allergens and preferences, and updates the UI of the profile and the meal cards in pages/food/index.jsx.

food page gets better helper functions and UI autumn of choices

Walkthrough

Robert27 commented 9 months ago

It might be a valid quick-fix, but im not sure if it's the best solution. Because currently it looks like you can now enjoy dishes at Reimann completely without allergens. Also people gonna ignore the tiny letters as soon as there is a huge red warning box on the other dishes.

I suggest consulting our UX-Team and do more research before making this decision. @leoonii

alexhorn commented 9 months ago

You are right that Reimanns does not have allergy information available. This is why the old UI showed "Allergene unbekannt" for Reimanns meals to alert the user about this.

As explained, my issue is that right now, losing your allergy configuration might lead the user to falsely believe that a dish is free of allergens because the warnings would disappear. From my point of view this is a safety issue.

Performing research on this should have been done before the allergy information was removed. The app should be first restored to a safe state and then we can talk about doing some research into alternative ways of implementing the allergy display that do not compromise user safety.

Robert27 commented 9 months ago

Okay, I would suggest we remove the allergen filtering completely and just show them all. This means we don't get into legal problems if our filter mechanism doesn't work…

Alternatively, I like the idea of a tooltip pop-up (like the dismissable install prompt) if allergens.length === 0, that explains the user how to set allergens and explicitly states that our app is not legal binding. This solution would allow us to maintain our current minimalist user interface and would have covered the scenario if the local storage is magically erased.

Anyway I just compared some other Mensa apps, most of them show the allergens only in the details page and the flags in the title. The apps that offer a filter function simply hide the dishes completely without presenting the problematic allergen...

alexhorn commented 9 months ago

I'm not sure if it's the ideal solution, but I have to agree that removing the filters completely and displaying all of the allergens all of the time is preferable over what we do now.

alexhorn commented 9 months ago

Merged manually due to safety concerns, continuing discussion in #380.

Robert27 commented 9 months ago

Shouldn't we also deploy this quick fix on master instead of just on develop?